Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only import Config if necessary #428

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix: only import Config if necessary #428

merged 1 commit into from
Nov 9, 2023

Conversation

mdonnalley
Copy link
Contributor

@mdonnalley mdonnalley commented Nov 8, 2023 •
edited
Loading

What does this PR do?

Only import Config if necessary and import directly from @salesforce/core/lib/config/config.js

What issues does this PR fix or reference?

@W-14455852@

@mdonnalley mdonnalley requested a review from a team as a code owner November 8, 2023 17:15
@mshanemc mshanemc merged commit cd38edc into main Nov 9, 2023
13 checks passed
@mshanemc mshanemc deleted the mdonnalley/perf branch November 9, 2023 17:45
@mshanemc
Copy link
Contributor

mshanemc commented Nov 9, 2023

QA: linked and built locally.

Ran a few commands (oclif and sf) with no issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshanemc mshanemc mshanemc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdonnalley @mshanemc